Allow JavaVariableLabelProvider's presentation to be overridden#639
Merged
iloveeclipse merged 2 commits intoeclipse-jdt:masterfrom Mar 26, 2025
Merged
Allow JavaVariableLabelProvider's presentation to be overridden#639iloveeclipse merged 2 commits intoeclipse-jdt:masterfrom
iloveeclipse merged 2 commits intoeclipse-jdt:masterfrom
Conversation
iloveeclipse
requested changes
Mar 14, 2025
Member
iloveeclipse
left a comment
iloveeclipse
left a comment
There was a problem hiding this comment.
May I ask you to do following: first commit would add new non-API code (and have updated commit message), second commit would do a cleanup, also with appropriate message. For the second commit, could you please also remove all (non-Javadoc) comments on methods? Thanks.
kysmith-csg
force-pushed
the
fix-internal-access
branch
from
b6da226 to
f9ce2ac
Compare
Contributor
Author
|
@iloveeclipse done, I hope this is what you meant |
iloveeclipse
approved these changes
Mar 26, 2025
iloveeclipse
force-pushed
the
fix-internal-access
branch
from
f9ce2ac to
2fb04d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mostly reverts a4eae7f (#580) for this file, as well as some code cleanup. Instead of making the fLabelProvider final, we initialize it to a default value as before but provide getters/setters so the field can still be private. Details in #580 for why I need this change, but in short it's because our product has a debugger that is tightly coupled to the JDT debugger, basically being an extension of it. Since this probably only affects me, your attention is greatly appreciated.
I don't understand this code enough to know why fLabelProvider is static, given that label providers are not meant to be shared, so I left it alone. Otherwise it would make more sense to have it as an instance field, maybe defined in an overloaded constructor.
I also thought to update the version of this plugin to 3.15 but Eclipse gave me an error when I did that about "no new APIs added" which I don't think is correct, but please let me know.